Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-8661 Document untracked branch tasks not having all expansions #8517

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ZackarySantana
Copy link
Contributor

DEVPROD-8661

Description

Untracked branches do not have access to the projectRef derived default expansions. I looked at the code here and it doesn't look like anything other than project, project_id and project_identifier are not exposed to the tasks of untracked branches.

@ZackarySantana ZackarySantana requested a review from a team December 2, 2024 19:58
@ZackarySantana ZackarySantana self-assigned this Dec 2, 2024
Copy link
Contributor

@Kimchelly Kimchelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod suggestion.

later projects, this is the unique hash, whereas for earlier
projects this is the same as `${project}`. If you aren't sure which
you are, you can check using this API route:
`https://evergreen.mongodb.com/rest/v2/<project_id>`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I know it was already like this, but would be preferable to link this to the route's docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked it!

@ZackarySantana ZackarySantana merged commit 0ded2b4 into evergreen-ci:main Dec 3, 2024
5 checks passed
@ZackarySantana ZackarySantana deleted the DEVPROD-8661_v2 branch December 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants